refactor(sidecars): move boot and the watchers out of index.ts - #2215

No actionable comments were generated in the recent review. 🎉

Merge Risk: ⚪ Minimal · up to d730e

This refactor moves sidecar startup and watcher code into separate modules without intended behavior changes. No concrete merge-blocking risk was found in the supplied context.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: moving sidecar boot logic and watchers from index.ts into dedicated sidecar modules.
Linked Issues check		Issue #2103 requires reusable sidecar boot code, separate watcher modules, no Electron imports under src/main/sidecars/, and watcher tests. The PR adds sidecars/boot.ts with BootContext, moves t…
Out of Scope Changes check		The reviewed changes are limited to sidecar source files, index.ts, and related tests. supervisor.ts and file-stamp.ts support the watcher extraction and sidecar control design. The changes do n…
Docstring Coverage		Docstring coverage is 90.32% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 31 functions across 10 files.

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands.}

@llwand1 is attempting to deploy a commit to the Rohan Verma's projects Team on Vercel.

A member of the Team first needs to authorize it.

Evidence for the linked checks (follow-up commit d730e64):

1. Docstring coverage — added JSDoc to the functions the diff touches (bootSidecars, watchAgentConfig, the internal reconcile functions, spawnOne, startAll, stopOne, stopAll, plus the settle test helpers and main/shutdown in index.ts). Comments only, no logic changes.

2. pnpm typecheck

$ tsc --noEmit -p tsconfig.json
exit 0

3. Tests — the watcher suites added by this step:

$ node --test src/main/sidecars/watch-audio-models.test.ts \
             src/main/sidecars/watch-generation-preset.test.ts \
             src/main/sidecars/watch-image-model.test.ts
# tests 13
# pass 13
# fail 0

And supervisor.test.ts: # pass 8, # skipped 1, # fail 0. The full suite is green in CI (Desktop Tests / Electron check above).

4. No Electron coupling — nothing under sidecars/ imports the electron module:

$ Select-String -Path "src/main/sidecars/*.ts" -Pattern "from ['""]electron['""]|require\(['""]electron['""]\)"
Import hits: 0

(The word "Electron" appears only inside comments.)

Ready for review — happy to address any feedback.

Merged into dev, thanks, and #2103 is closed. Line by line, the moved boot and watchers do what they did before, and returning before /health keeps a failed start reaped now that boot.ts can't set index.ts's variables. Two things for your next step, neither blocking:

1. apiUrl is now set before the API answers. index.ts:481 assigns apiUrl = boot.apiUrl before await boot.waitHealthy() at :485, while the comment at :77 still says "once it answers". On macOS, Cmd+Q during startup now sends GET /chat/runs to an API that isn't up, and waits up to 2 s for it, where it used to quit at once. Moving that one line below the health wait restores it.
2. waitHealthy only fails fast if the API dies after it's called. boot.ts:178 passes sidecars.get("api") to waitForHealth, which listens with child.once("exit"), so an exit that has already happened is missed. Electron calls it at once, so nothing breaks today, but step 5's headless entry would sit out the full 60 s and report "not healthy" instead of "sidecar exited during startup". Check exitCode/signalCode first.

Small, for when you're there: no test checks the stop function each watcher returns (a return () => {} passes all 13), and the new files have no trailing newline.